spring-projects / spring-projects/spring-security
Consider erroring when client authentication method is basic
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Questions like https://stackoverflow.com/questions/75224023/spring-oauth2-login-not-working-after-migrating-to-spring-boot-3 indicate that it's not clear that clientAuthenticationMethod: basic is no longer a supported value for ClientAuthenticationMethod.
We should consider erroring and telling applications to change basic to client_secret_basic and post to client_secret_post.
(Note: this could also be done in Spring Boot possibly, though I think we should first consider doing it in Spring Security since we can catch more misconfigurations that way)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with ClientAuthenticationMethod configuration and the linked Spring Security migration documentation. Determine where the values basic and post are processed, then define error messages directing applications to client_secret_basic and client_secret_post; done means unsupported aliases produce clear errors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring, spring-boot
- Domain
- authentication, security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100