spring-projects / spring-projects/spring-security

Resolve ContentNegotiationStrategy from ApplicationContext

Open
#12,028 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

in: config type: enhancement
Dominant language
Java
Stars
9.6k
Forks
6.3k
Avg merge
2d 11h
Merged PRs (30d)
52

Description

https://github.com/spring-projects/spring-security/issues/11916 made the ContentNegotiationStrategy bean available as a shared object in HttpSecurity. However, it is not optimal when thinking about simplifying the HttpSecurity construction (#7449, #11633).

We should change the places where the ContentNegotiationStrategy is being retrieved from the shared objects and retrieve it from the ApplicationContext.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the Spring Security codebase for places where ContentNegotiationStrategy is retrieved from HttpSecurity shared objects, then read the related construction paths and issues #7449, #11633, and #11916. Done means those retrievals use the ApplicationContext instead, with the affected behavior still covered by the project's tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
security
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.