spring-projects / spring-projects/spring-security

SecurityMockMvcResultMatchers - Kotlin examples don't trigger assertions

Open
#11,793 3 comments 1 reaction 1 assignee View on GitHub

@sjohnr is already working on this.

Since Sep 9, 2022.

in: docs type: bug
Dominant language
Java
Stars
9.6k
Forks
6.3k
Avg merge
2d 11h
Merged PRs (30d)
52

Description

Describe the bug

https://github.com/spring-projects/spring-security/blob/5.7.3/docs/modules/ROOT/pages/servlet/test/mockmvc/result-matchers.adoc#authenticated-assertion

The Kotlin examples for the MockMvc assertions call the Java functions, but these methods are not compatible with the Kotlin DSL, and so this test will always pass:

fun `user should be authenticated`() {
  mvc
      .perform(formLogin())
      .andExpect { authenticated() }
      .andExpect { unauthenticated() }
      .andExpect { authenticated().withRoles("USER", "ADMIN") }
      .andExpect { authenticated().withRoles("blah", "qwerty") }
}

authenticated() returns a AuthenticatedMatcher instance, but the returned value isn't used for anything.

Expected behavior

The examples for Kotlin SecurityMockMvcResultMatchers are corrected.

Sample

mvc-kt-matchers.zip

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.