spring-projects / spring-projects/spring-security

Allow Saml2MetadataFilter to work without AssertingPartyDetails in RelyingPartyRegistration

Open
#11,369 5 comments 4 reactions 1 assignee View on GitHub

@jzheaux is already working on this.

Since Jun 14, 2022.

in: saml2 type: enhancement
Dominant language
Java
Stars
9.6k
Forks
6.3k
Avg merge
2d 11h
Merged PRs (30d)
52

Description

Expected Behavior

Saml2MetadataFilter should not require information about an identity provider / asserting party in order to generate the metadata. The RelyingPartyRegistration is intended to be a representation of both the relying part and the asserting party. Since the metadata is a representation solely of the relying party not sure if the RelyingPartyRegistration should be used or potentially modified to allow creating the RelyingPartyRegistration without AssertingPartyDetails.

Current Behavior

Current behavior utilizes RelyingPartyRegistration which requires AssertingPartyDetails to be configured.

Context
We are having to add fake data to the asserting party details that is part of RelyingPartyRegistration in order to generate metadata.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.