spring-projects / spring-projects/spring-security

an encode and decode bug in AbstractRememberMeServices

Open
#111 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

status: waiting-for-triage
Dominant language
Java
Stars
9.6k
Forks
6.3k
Avg merge
2d 11h
Merged PRs (30d)
52

Description

in the tag "4.0.0.M1",
the method "AbstractRememberMeServices#decodeCookie()" and "AbstractRememberMeServices#encodeCookie()" can NOT exactly be the inverse operation when the operation system default charset is GBK!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with AbstractRememberMeServices#encodeCookie() and AbstractRememberMeServices#decodeCookie() in the 4.0.0.M1 code, then reproduce the round trip using a GBK operating-system default charset. Compare the encoded and decoded values and verify that the two operations are exact inverses under that charset.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
authentication, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.