spring-projects / spring-projects/spring-security
Add generic type to CsrfTokenRepository
Open
Nobody has claimed this yet.
in: web
type: enhancement
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
To improve handling of CsrfToken instances generated by a CsrfTokenRepository, consider adding a generic type similar to SessionRepository in spring-session.
For example:
public interface CsrfTokenRepository<T extends CsrfToken> {
T generateToken(HttpServletRequest request);
...
}
Related gh-4001
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the CsrfTokenRepository interface and related issue gh-4001, then compare the proposed shape with spring-session's SessionRepository. Assess the impact of parameterizing the repository and changing generateToken to return T. Done means the API supports T extends CsrfToken and the affected repository usage remains coherent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100