spring-projects / spring-projects/spring-security-samples

Spring Security samples with XML configuration not working as its web.xml is pointing to old servelet 2.5 & 3.0

Open
#346 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
1.8k
Forks
797
Avg merge
3m
Merged PRs (30d)
5

Description

It seems that there is a significant issue regarding the compatibility of the Spring Security samples with XML configuration. Currently, the samples are not functioning as intended with the existing XML configuration, and it has come to our attention that the web.xml file has not been updated to meet the necessary requirements for Servlet 6, which is essential for proper functionality.

In light of these circumstances, it would be prudent to discuss the possibility of updating the sample applications. By doing so, we can ensure that they are compatible with XML configuration, thereby enhancing their usability and effectiveness.

This update would not only address the current incompatibility issues but also align the applications with the latest standards and requirements.

Ref:
contacts Sample App
https://github.com/spring-projects/spring-security-samples/blob/main/servlet/xml/java/contacts/src/main/webapp/WEB-INF/web.xml
(Pointing to servelet 2.5)

helloworld Sample App
https://github.com/spring-projects/spring-security-samples/blob/main/servlet/xml/java/helloworld/src/main/webapp/WEB-INF/web.xml(Pointing to servelet 3.0)

preauth Sample App
https://github.com/spring-projects/spring-security-samples/blob/main/servlet/xml/java/preauth/src/main/webapp/WEB-INF/web.xml
(Pointing to servelet 2.5)

saml2 Sample App
https://github.com/spring-projects/spring-security-samples/blob/main/servlet/xml/java/saml2/login-logout/src/main/webapp/WEB-INF/web.xml
(Pointing to servelet 3.0)

Thanks
Syed Riazur Rahman

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the four referenced WEB-INF/web.xml files in the contacts, helloworld, preauth, and saml2 sample applications, and compare their servlet declarations with the Servlet 6 requirement. Verify the XML-configured samples after the declarations are updated; done means these sample applications no longer point to Servlet 2.5 or 3.0 and function with Servlet 6.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
backend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.