spring-projects / spring-projects/spring-security-samples
OAuth Sample Do not Test Actual Configuration
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.8k
- Forks
- 797
- Avg merge
- 3m
- Merged PRs (30d)
- 5
Description
Summary
As it stands the tests that are in Spring Security's OAuth Samples do not test the actual configuration. They are instead copying and modifying the samples to allow testing.
This might seem innocent enough, but we don't want our users to follow this pattern. We need to demonstrate how the existing configuration can be used with perhaps mocking a small piece of the application or running a MockWebServer instance
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the OAuth Samples and their existing tests to identify where tests copy and modify sample configuration. Start by comparing those test setups with the shipped configurations. Done means the tests exercise the actual sample configuration while mocking only a small application component or using a MockWebServer instance.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- authentication, authorization, testing
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100