spring-projects / spring-projects/spring-modulith

Back-port script doesn't work with pull requests as sources

Open
#990 0 comments 0 reactions 1 assignee View on GitHub

@ciberkleid is already working on this.

Since Dec 11, 2024.

in: infrastructure type: task
Dominant language
Java
Stars
1.2k
Forks
222
No merged PRs in 30d

Description

The check in isValidIssueNumber() uses gh issue list … to find the source ticket, which unfortunately doesn't include pull requests. We might additionally check for PRs (gh pr list …) or rather use gh issue view $number.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.