spring-projects / spring-projects/spring-modulith
Thoughts on changing visibility of EventRepository-related classes to public
Open
@odrotbohm is already working on this.
Since Apr 16, 2024.
in: event publication registry
meta: waiting for feedback
- Dominant language
- Java
- Stars
- 1.2k
- Forks
- 222
- PR merge metrics
- No merged PRs in 30d
Description
Currently, different implementations of EventPublicationRepository and their related classes (e.g., JdbcEventPublicationRepository, JdbcEventPublicationRepository and its JpaEventPublication, MongoDbEventPublicationRepository and its MongoDbEventPublicationRepository, etc.) have package-protected visibility.
This makes it impossible to reuse any of these classes, and even for simple customizations the only alternative left is copying & pasting all the classes. Wouldn't it make more sense to change visibility to public, to ease extensibility?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.