spring-projects / spring-projects/spring-modulith

Spring Modulith Events JPA ojdbc11 timestamp

Open
#1,194 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
1.2k
Forks
222
PR merge metrics
No merged PRs in 30d

Description

Hello,

After migrating to ojdbc11:

<dependency>
            <groupId>com.oracle.database.jdbc</groupId>
            <artifactId>ojdbc11</artifactId>
</dependency>

we noticed our integration tests started to fail with:

org.springframework.orm.jpa.JpaSystemException: Could not extract column [5] from JDBC ResultSet [ORA-18716: {0} not in any time zone.DATE
https://docs.oracle.com/error-help/db/ora-18716/] [n/a]

When trying to fetch incomplete publications:

 Collection<TargetEventPublication> failures = eventPublicationRegistry.findIncompletePublications();

We used the schema-oracle.sql to create the tables and it seems it needs a default timezone for this to work again

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with spring-modulith-events/spring-modulith-events-jdbc/src/main/resources/schema-oracle.sql and inspect the timestamp columns used when findIncompletePublications() fetches incomplete publications. Reproduce the failure with ojdbc11 and the affected integration tests; done means those tests can fetch incomplete publications without the ORA-18716 timezone error.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
database
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.