spring-projects / spring-projects/spring-integration
Make destination ref and name properties consistent for JMS adapters [INT-920]
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.6k
- Forks
- 1.2k
- Avg merge
- 17h 48m
- Merged PRs (30d)
- 62
Description
Mark Fisher opened INT-920 and commented
All adapters use attributes named "destination" when the actual reference is expected, and that is fine.
However, when expecting a name, some use a combination of "destination-name" and "pub-sub-domain" while others avoid the need for that boolean by using "queue-name" OR "topic-name". We should refactor such that ALL of the adapters use the mutually exclusive "queue-name" or "topic-name" attributes.
Affects: 2.0 M1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating all JMS adapter definitions and compare how they expose destination-name, pub-sub-domain, queue-name, and topic-name. The work is done when every adapter consistently uses the mutually exclusive queue-name or topic-name attributes; no files or tests are identified in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100