spring-projects / spring-projects/spring-hateoas
Investigate move to DefaultUriBuilderFactory in ControllerLinkBuilder
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.1k
- Forks
- 476
- PR merge metrics
- No merged PRs in 30d
Description
ControllerLinkBuilder is currently using an extension of DefaultUriTemplateHandler to control which parts of a UriComponentsBuilder get encoded on expansion. DUTH has been deprecated since Spring 5.0 in favor of DefaultUriBuilderFactory whose usage pattern seems to differ from DUTH and indicates it might allow us to fundamentally revisit the usage of UriComponents/…Builder in the class hierarchy of LinkBuilderSupport.
We probably need to consult @rstoyanchev on that one.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading ControllerLinkBuilder and the LinkBuilderSupport class hierarchy, focusing on the current DefaultUriTemplateHandler extension and its UriComponents usage. Compare that pattern with DefaultUriBuilderFactory and consult the maintainer identified in the issue. Done means an agreed direction for the migration and any resulting hierarchy changes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- api
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100