spring-projects / spring-projects/spring-hateoas

Deserialization of empty array of links fails

Open
#790 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
1.1k
Forks
476
PR merge metrics
No merged PRs in 30d

Description

The following test fails

assertThat(read("{\"_links\":[]}",ResourceSupport.class).getLinks().size()).isEqualTo(0);

the issue could be solved the following way

if (!JsonToken.FIELD_NAME.equals(jp.getCurrentToken())) {
	if(result.isEmpty() && JsonToken.END_ARRAY.equals(jp.getCurrentToken())){
		continue;
	}
	throw new JsonParseException(jp, "Expected relation name");
}

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the failing read("{"_links":[]}", ResourceSupport.class) test and locate the JSON link deserialization path. Check the parser's handling of the current token for an empty _links array, then verify that the test passes without breaking non-empty link parsing.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend-api-design
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.