spring-projects / spring-projects/spring-hateoas

Base URL for ControllerLinkBuilder

Open
#516 7 comments 0 reactions 1 assignee View on GitHub

@gregturn is already working on this.

Since May 25, 2017.

process: in progress
Dominant language
Java
Stars
1.1k
Forks
476
PR merge metrics
No merged PRs in 30d

Description

There are several tickets requesting to influence the URLs that the ControllerLinkBuilder creates. I'd like to propose another variation:

I'd like an option to have ControllerLinkBuilder build links with a fixed, configured base URL instead of the information extracted from the servlet request. My use case is having redundant service instances that are accessed by client side load balancing from other services within the same application. I'd like to configure that base URL as an environment property, and in my case use spring.application.name as host name as this is the service name in eureka. There's a bit more context in this Stack Overflow question.

  • #420 makes a similar request but focuses on the implementation
  • #408 and #330 propose relative links instead (which probably could be considered in a solution for this)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.