spring-projects / spring-projects/spring-hateoas
ControllerLinkBuilder does not take Spring Data REST's base path into account
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.1k
- Forks
- 476
- PR merge metrics
- No merged PRs in 30d
Description
I have the repository REST base path set to /rest, and a @RepositoryRestController with some custom handlers:
@RepositoryRestController
public class RestController {
@RequestMapping(value = "/foo", method = RequestMethod.GET)
public ResponseEntity<Bar> foo() {
return new ResponseEntity<>(new Bar(), HttpStatus.OK);
}
...
}
public class Bar extends ResourceSupport {
public Bar() {
...
add(linkTo(methodOn(RestController.class).foo()).withSelfRel());
}
}
The endpoint works fine at http://localhost:8080/rest/foo, however, the link is incorrect:
{
...
_links: {
self: {
href: "http://localhost:8080/foo"
}
}
}
For some reason, the base path (/rest) was ignored.
I'm using Spring HATEOAS 0.19.0.RELEASE (comes with Spring Boot 1.3.1.RELEASE).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with ControllerLinkBuilder and the @RepositoryRestController example, then reproduce the issue with Spring Data REST's base path set to /rest. Trace how the custom handler link is built and verify that the generated self link includes /rest rather than pointing to the application root.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100