spring-projects / spring-projects/spring-hateoas

WebMvcLinkBuilder does not resolve "EmmbeddedValues" correctly.

Open
#1,855 0 comments 6 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
1.1k
Forks
476
PR merge metrics
No merged PRs in 30d

Description

When using "Embedded Values" in spring, WebMvcLinkBuilder does not correctly resolve the value. This does not seem to be an esoteric way of writing a RestController, as among other things this is how the OpenAPI generator generates server stubs.

Example:

@RestController
@RequestMapping("${openapi.example.base-path:/example}")
public class HelloController {
}

Failing Test:

@Test
void LinkBuilderAndSpringEmbeddedValueResolver() {
    var result = WebMvcLinkBuilder.linkTo(HelloController.class)
                    .withRel("example");
    assertThat(result).extracting(Link::getHref).isEqualTo("http://localhost/example");
}

Result:

expected: "http://localhost/example"
 but was: "http://localhost/example}"

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the provided failing test and trace how WebMvcLinkBuilder processes the HelloController @RequestMapping value containing an embedded placeholder. Confirm the generated link ends at /example rather than retaining the closing brace, and use the test's expected href as the completion check.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.