spring-projects / spring-projects/spring-hateoas

WebMvcLinkBuilder fails with a non-optional request parameter when calling toUriComponentsBuilder()

Open
#1,826 2 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Sep 14, 2022.

process: waiting for feedback
Dominant language
Java
Stars
1.1k
Forks
476
PR merge metrics
No merged PRs in 30d

Description

When using WebMvcLinkBuilder to build a link to a controller method with a non-optional request parameter, invoving toUriComponentsBuilder() fails.

Version 1.5.0 is fine, 1.5.1 has the issue.

I've created a demo here

https://github.com/spstorey/linkissue/blob/main/src/main/java/com/example/linkissue/RootController.java

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.