spring-projects / spring-projects/spring-hateoas

SpringAffordanceBuilder handles request parameters always as query parameters

Open
#1,685 2 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Oct 19, 2021.

process: waiting for feedback
Dominant language
Java
Stars
1.1k
Forks
476
No merged PRs in 30d

Description

When SpringAffordanceBuilder creates affordances from a controller method it handles request parameters always as query parameters. This should only be the case for GET methods or methods with an @RequestBody parameter. Otherwise, it should create a InputPayloadMetadata. InputPayloadMetadata could be useful for GET, too, because a HAL-FORM contains more information than a templated URL.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.