spring-projects / spring-projects/spring-framework
`ResolvableType::isInstance` should respect AOP proxy
Open
Nobody has claimed this yet.
status: waiting-for-triage
- Dominant language
- Java
- Stars
- 60.2k
- Forks
- 38.8k
- Avg merge
- 5d 2h
- Merged PRs (30d)
- 27
Description
Currently doesn't detect target wrapped by proxy.
boolean b1 = resolvableType.isInstance(target); // true
// wrap target to JDK Dynamic Proxy
boolean b2 = resolvableType.isInstance(proxy); // false
See https://github.com/spring-projects/spring-framework/pull/37047#issue-4879201728
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at ResolvableType::isInstance and read the linked pull request for context on the JDK Dynamic Proxy case. Trace how the target and proxy are inspected, then verify that the proxy produces the expected instance result and add or update coverage for the shown example.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100