spring-projects / spring-projects/spring-framework
Wrong localization order in ResponseStatusException.updateAndGetBody()
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 60.2k
- Forks
- 38.8k
- Avg merge
- 5d 2h
- Merged PRs (30d)
- 27
Description
In cases where reason on ResponseStatusException is not manually set, I expect localization key equal to problemDetail.org.springframework.web.server.ResponseStatusException to act as a fallback; but since super.updateAndGetBody() is called before instead of after custom logic, this localization acts as an overwrite instead.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at ResponseStatusException.updateAndGetBody() and inspect the order of its superclass call and custom localization logic. Verify the behavior when reason is unset: the problemDetail.org.springframework.web.server.ResponseStatusException localization should provide a fallback rather than overwrite the existing result.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100