spring-projects / spring-projects/spring-framework

Determine why `reactorNettyAttributes()` in `WebClientIntegrationTests` is flaky

Open
#36,589 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type: task
Dominant language
Java
Stars
60.2k
Forks
38.8k
Avg merge
5d 2h
Merged PRs (30d)
27

Description

Overview

The reactorNettyAttributes() test method fails intermittently as follows.

org.opentest4j.AssertionFailedError: 	
expected: null	
 but was: {"org.springframework.web.reactive.function.client.ClientRequest.LOG_ID"="2a2cdba0", "org.springframework.web.reactive.function.client.WebClient.uriTemplate"="http://localhost:45573/greeting"}	
at org.springframework.web.reactive.function.client.WebClientIntegrationTests.reactorNettyAttributes(WebClientIntegrationTests.java:1344)

This occurs on the CI server as well as locally.

In the interim I have @Disabled that test method.

Related Issues

  • #36158

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the disabled reactorNettyAttributes() method in WebClientIntegrationTests.java at line 1344, then reproduce the intermittent assertion failure locally and compare it with the CI failure. Review related issue #36158 for context. Done means the cause is identified and the test can be reliably enabled without the unexpected attributes assertion.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend-api-design, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.