spring-projects / spring-projects/spring-framework

Consider adding a `gradle-daemon-jvm.properties` file

Open Beginner friendly
#35,766 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

status: waiting-for-triage
Dominant language
Java
Stars
60.2k
Forks
38.8k
Avg merge
5d 2h
Merged PRs (30d)
27

Description

As of the change made in https://github.com/spring-projects/spring-framework/commit/7edb0b339719db49803f5a81c9501816d75077b0, spring-framework now requires java 25 to build. Furthermore spring-framework now builds with Gradle 9.2.0 https://github.com/spring-projects/spring-framework/commit/9c0f7146392d4883e43ce2a1016fe15a879bfe38 which [promoted[(https://docs.gradle.org/current/release-notes.html#daemon-toolchain-is-now-stable) the daemon toolchain feature.

This should be as simple as adding a gradle/gradle-daemon-jvm.properties file with the following contents.

#This file is generated by updateDaemonJvm
toolchainVersion=25

This would alert users if a developer does not have a valid installation of java 25 available.

Unable to download toolchain matching the requirements ({languageVersion=25, vendor=any vendor, implementation=vendor-specific, nativeImageCapable=false}) from 'null', due to: No defined toolchain download url for MAC_OS on aarch64 architecture.

This feature is also supported by Intellij, which will correctly display the version of java required by the daemon jvm file.

Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by checking the existing gradle/ directory and the referenced Gradle daemon toolchain documentation. Add gradle/gradle-daemon-jvm.properties with the requested Java 25 toolchain setting, then verify that Gradle and IntelliJ recognize the required daemon JVM.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system
Issue type
Feature
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
62/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.