spring-projects / spring-projects/spring-framework
Identify invalid factory methods AOT when possible
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 60.2k
- Forks
- 38.8k
- Avg merge
- 5d 2h
- Merged PRs (30d)
- 27
Description
As discussed with @snicoll and @jhoeller while working on #32719, InstanceSupplierCodeGenerator#generateCode currently does not perform the same checks than org.springframework.beans.factory.support.ConstructorResolver#instantiateUsingFactoryMethod except the recent suspending function check added recently.
It would be nice from a DevXP and consistency perspective if it could perform AOT some of those checks (like the void return type check for example).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing InstanceSupplierCodeGenerator#generateCode with ConstructorResolver#instantiateUsingFactoryMethod, using the existing suspending function check as the reference point. Identify which factory-method validations can be performed during AOT generation, including the void return type check, and verify that the generated diagnostics are consistent with runtime behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- backend, developer-experience
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100