spring-projects / spring-projects/spring-framework
Improve invocation order for advice within an <aop:aspect>
Open
Nobody has claimed this yet.
in: core
type: enhancement
- Dominant language
- Java
- Stars
- 60.2k
- Forks
- 38.8k
- Avg merge
- 5d 2h
- Merged PRs (30d)
- 27
Description
Overview
Due to tests implemented in conjunction with #25186, it has come to our attention that advice ordering within a single aspect configured via the <aop:aspect> XML configuration element may not be desirable and is at least not intuitive.
Related Issues
- #24673
- #25186
Deliverables
- Determine what changes (if any) should be made the advice sorting within a single
<aop:aspect>element - Update documentation in the reference manual accordingly
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the tests associated with #25186 and the related discussion in #24673 to determine the current advice ordering for a single aop:aspect element. Then inspect the reference manual's documentation of that XML configuration and establish the intended ordering before deciding whether code or documentation changes are needed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- backend, documentation
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100