spring-projects / spring-projects/spring-framework
WebFlux equivalent of MvcUriComponentsBuilder [SPR-15953]
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 60.2k
- Forks
- 38.8k
- Avg merge
- 5d 2h
- Merged PRs (30d)
- 27
Description
Arjen Poutsma opened SPR-15953 and commented
We could use a WebFluxUriComponentsBuilder that has similar functionality as the ServletUriComponentsBuilder,
An additional method that WebFluxUriComponentsBuilder should have is fromServerRequest, taking a ServerRequest from WebFlux.fn, as that type does not implement HttpRequest, and therefore cannot be used with UriComponentsBuilder.fromHttpRequest.
Issue Links:
- #20485 ReactorServerHttpRequest.getUri() does not include scheme
- #20546 WebFlux support for UriBuilder, UriComponentsBuilder controller method arguments
Referenced from: commits https://github.com/spring-projects/spring-framework/commit/1a3cc3df94c0f8e504f36e9be8e6f2ded5a12750, https://github.com/spring-projects/spring-framework/commit/a7617a264120ca486d7c92bb4255ec1ac3ef986e
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the requested WebFluxUriComponentsBuilder with ServletUriComponentsBuilder and UriComponentsBuilder, then inspect ServerRequest from WebFlux.fn and the linked URI-related issues. Done means WebFlux has equivalent URI-building support, including a fromServerRequest method that handles ServerRequest input.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- api, backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100