spring-projects / spring-projects/spring-data-rest

PersistentEntityResourceHandlerMethodArgumentResolver does not throw Exception [DATAREST-611]

Open
#984 1 comment 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 31, 2020.

type: bug
Dominant language
Java
Stars
958
Forks
568
PR merge metrics
No merged PRs in 30d

Description

Pablo Santiago opened DATAREST-611 and commented

When doing a really silly test:

mockMvc.perform(patch("/accounts/{id}", UUID.randomUUID()).contentType(APPLICATION_JSON).content(accountJSON()).andExpect(status().isNotFound());

I get a NullPointerException in PersistentEntityResourceHandlerMethodArgumentResolver due to:

if (objectToUpdate == null) {
    new ResourceNotFoundException();
}

[lines 155-157]

Please not that it lacks the throws keyword, so it swallows the Exception


Affects: 2.4 M1 (Gosling), 2.2.3 (Evans SR3)

1 votes, 2 watchers

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.