spring-projects / spring-projects/spring-data-rest

Link discovery by looking at repository finders [DATAREST-600]

Open
#974 4 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 31, 2020.

in: repository type: enhancement
Dominant language
Java
Stars
958
Forks
568
PR merge metrics
No merged PRs in 30d

Description

Oliver Trosien opened DATAREST-600 and commented

At the moment structural links of a resource get populated by looking at the properties of an entity. This is fine so far, but Spring Data REST could do better. If you have a repository finder that takes an entity as input, it could actually be rendered as structural link from this entity. Example:

entity Product 
entity CustomerRating

repository CustomerRatingRepository {
  Page<CustomerRating> findByProduct(@Param("product") Product p, Pageable pageable);
}

Of course I could add a @OneToMany from Product to CustomerRating, but let's assume this would break modularity of my system. Still it would be nice to have a link on the REST API from a product to its customer ratings. What do you think? Is this a valid use case? Is this possible (e.g. adding annotations to the finder)?


Issue Links:

  • DATAREST-725 Support pagination and sorting on association resources

1 votes, 4 watchers

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.