spring-projects / spring-projects/spring-data-rest
Support query parameters both as link and as primary key. [DATAREST-590]
@odrotbohm is already working on this.
Since Dec 31, 2020.
- Dominant language
- Java
- Stars
- 958
- Forks
- 568
- PR merge metrics
- No merged PRs in 30d
Description
Petar Tahchiev opened DATAREST-590 and commented
Following on from
https://jira.spring.io/browse/DATAREST-502
I would like to propose to support both syntax queries:
https://localhost:8112/storefront/rest/product/search/findAllByCatalogVersionEquals?catalogVersion=123
and
https://localhost:8112/storefront/rest/product/search/findAllByCatalogVersionEquals?catalogVersion=https://localhost:8112/storefront/rest/product/564488177061440/catalogVersion
As I already mentioned in DATAREST-502 the PK format is currently not supported because of the following lines in UriToEntityConverter:
if (parts.length < 2) {
throw new ConversionFailedException(sourceType, targetType, source, new IllegalArgumentException(
"Cannot resolve URI " + uri + ". Is it local or remote? Only local URIs are resolvable."));
}
No further details from DATAREST-590
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.