spring-projects / spring-projects/spring-data-rest
Absolute base uri with multiple components fails [DATAREST-564]
@odrotbohm is already working on this.
Since Dec 31, 2020.
- Dominant language
- Java
- Stars
- 958
- Forks
- 568
- PR merge metrics
- No merged PRs in 30d
Description
Dave Handy opened DATAREST-564 and commented
This test case fails, because BaseUri is trying to reverse an unmodifiable collection. A slightly broader question is why the getRepositoryLookup path logic is so different for absolute base URIs versus relative base URI.
import org.junit.Test;
import org.springframework.data.rest.webmvc.BaseUri;
public class BaseUriTest {
@Test
public void testbaseURi() {
BaseUri base = new BaseUri("https://example.com/services/v1/");
base.getRepositoryLookupPath("");
}
}
Caused by: java.lang.UnsupportedOperationException: null
at java.util.Collections$UnmodifiableList.set(Collections.java:1311)
at java.util.Collections.swap(Collections.java:497)
at java.util.Collections.reverse(Collections.java:378)
at org.springframework.data.rest.webmvc.BaseUri.getRepositoryLookupPath(BaseUri.java:130)
Affects: 2.2.2 (Evans SR2)
1 votes, 4 watchers
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.