spring-projects / spring-projects/spring-data-rest

Entity with Jackson Builder throws exception when updated with Repository through HTTP PUT [DATAREST-536]

Open
#912 0 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 31, 2020.

type: bug
Dominant language
Java
Stars
958
Forks
568
PR merge metrics
No merged PRs in 30d

Description

Glenn Boschmans opened DATAREST-536 and commented

When using the builder pattern in Jackson to deserialize an entity, updating an entity with PUT throws an exception. In the class com.fasterxml.jackson.databind.deser.impl.MethodProperty the method setAndReturn receives the wrong object for parameter instance. When you debug it, you will see that a POST will have the Builder object as the instance parameter and a method is invoked on it.
However, when you do a PUT the instance parameter is the entity instead of the builder, on which the builder method is invoked. This throws the exception that you find in attachment stacktrace.log.

A project which reproduces the issue can also be found as an attachment.
Run/Debug as a Spring Boot application and do a POST on <host>:9666/testcases with following content
{
"someStuff": "text",
"date": "2015-05-06"
}

Do a PUT on <host>:9666/testcases/2 with following content
{
"someStuff": "text",
"date": "2015-05-07"
}


Affects: 2.2.2 (Evans SR2)

Attachments:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.