spring-projects / spring-projects/spring-data-rest

Provide getters in PersistentEntityToJsonSchemaConverter [DATAREST-400]

Open
#777 0 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 31, 2020.

type: bug
Dominant language
Java
Stars
958
Forks
568
PR merge metrics
No merged PRs in 30d

Description

Petar Tahchiev opened DATAREST-400 and commented

So I've been playing around lately with PersistentEntityToJsonSchemaConverter and I would like to extend it so I can override the convert method. Unfortunately when I do so I also have to specify a constructor to hold the instance variables, and I can't access the repositories, mappings and entityLinks from the parent. It would be nice to have a getter method in the parent so that I can call it. Also the resolveMessage method is private and I can't use it. Can you please make it protected?


No further details from DATAREST-400

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.