spring-projects / spring-projects/spring-data-rest
Associations to unexported repositories are broken [DATAREST-376]
@odrotbohm is already working on this.
Since Dec 31, 2020.
- Dominant language
- Java
- Stars
- 958
- Forks
- 568
- PR merge metrics
- No merged PRs in 30d
Description
Olivier Sels opened DATAREST-376 and commented
DATAREST-262 added support for nested associations to embeddables. However this also creates problems with associations to unexported repositories, even if they shouldn't be serialized at all.
With a single association this results in duplicate links with the same name. With another nested relation this eventually results in an infinite loop as LinkCollectingAssociationHandler:doWithAssociation is repeatedly called when links are being discovered.
Removing the else clause resolves this problem for us as the jackson serialization works correctly. However then it breaks tests for DATAREST-262.
I've included my data model and simple test to illustrate the problem
Affects: 2.1.2 (Dijkstra SR2), 2.2 RC1 (Evans)
Attachments:
- DataRestSecretTests.java (4.70 kB)
1 votes, 2 watchers
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.