spring-projects / spring-projects/spring-data-rest

StringToPointConverter - Split using semicolon [DATAREST-367]

Open
#748 0 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 31, 2020.

type: bug
Dominant language
Java
Stars
958
Forks
568
PR merge metrics
No merged PRs in 30d

Description

Gunnar Hillert opened DATAREST-367 and commented

In class org.springframework.data.rest.webmvc.convert.StringToPointConverter we should either change the message:

"Expected two doubles separated by a semicolon but got '%s'!"

or change:

String[] parts = source.split(",");

to use an actual semicolon. Looks like an actual semicolon would be less ambiguous.


Affects: 2.2 RC1 (Evans)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.