spring-projects / spring-projects/spring-data-rest

Extending filter options when accessing /entities/...

Open
#72 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

status: waiting-for-triage
Dominant language
Java
Stars
958
Forks
568
PR merge metrics
No merged PRs in 30d

Description

Hi Jon,
me again, who comes up with a request. I talked to @olivergierke last saturday, and a feature that is really missing is the ability to filter based on the current user role. Oliver and me discussed various advantages and disadvantages using @PostAuthorize or @PreAuthorize. Both solutions have significant drawbacks. What we thought of was something like an extension of the query:


@Query("where entity.user = :user")
findAll(@Param("user") User user)

The difficulty here is definitely to set this findAll(User user..) as the default lookup, and or even worse, if the current role is the "application administrator", to switch it with a pure findAll() without any user filter.

Perhaps we could use this issue do discuss several scenarios and potential solutions to the problem described.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the /entities/... access path and the findAll(User user) query example described in the issue. Review how Spring Data REST selects the default repository lookup and how the current user role affects that choice. Done means the role-based filtering scenarios and a solution are agreed and implemented.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
api, authorization, backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.