spring-projects / spring-projects/spring-data-rest

Base URL configuration ignored when creating pagination links [DATAREST-270]

Open
#650 4 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 31, 2020.

type: bug
Dominant language
Java
Stars
958
Forks
568
PR merge metrics
No merged PRs in 30d

Description

Aaron Loes opened DATAREST-270 and commented

BUILD: 2.0.0.BUILD-20140129.145024-33
Not sure if this has been fixed as we are locked onto an old 2.0.0.BUILD-SNAPSHOT version.

Have set the base URL in the configuration via a call to RepositoryRestConfiguration#setBaseUri in my application configuration. This works in that the repository and entity URL's are correctly constructed. However, links on Resources (e.g. self, next, prev) do not take this setting into consideration. This is a big problem when our application lives on a load balancer and/or is behind a proxy


Affects: 2.0 M1 (Codd)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.