spring-projects / spring-projects/spring-data-rest

Using X-Forwarded-Host header for building links

Open
#65 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

status: waiting-for-triage
Dominant language
Java
Stars
958
Forks
568
PR merge metrics
No merged PRs in 30d

Description

This was recently added to spring-hateoas: https://github.com/SpringSource/spring-hateoas/issues/33

Can this work for spring-data-rest as well?

Thanks.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the linked spring-hateoas issue and tracing how spring-data-rest currently builds links. Determine the expected behavior for the X-Forwarded-Host header, then identify how generated links can be verified in this repository. Done means spring-data-rest builds links using that header consistently with spring-hateoas.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
api, backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.