spring-projects / spring-projects/spring-data-rest

Null-pointer exception when the class is not mapped. [DATAREST-174]

Open
#559 2 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 31, 2020.

type: enhancement
Dominant language
Java
Stars
958
Forks
568
PR merge metrics
No merged PRs in 30d

Description

Petar Tahchiev opened DATAREST-174 and commented

Hi guys,

here's an improvement to think about. I have a class called AbstractComponent, with a repository called AbstractComponentRepository. The AbstractComponent is a superclass for a lot of different components (like BannerComponent, SliderComponent, GooglemapComponent, etc..). Right now if I go to the url of my rest AbstractComponentRepository it throws a null-pointer exception because none of the components are of AbstractComponent class. So this code here:

		PersistentEntity<?, ?> entity = repositories.getPersistentEntity(instance.getClass());

		BeanWrapper<?, Object> wrapper = BeanWrapper.create(instance, null);
		Object id = wrapper.getProperty(entity.getIdProperty());

		return entityLinks.linkForSingleResource(entity.getType(), id).withSelfRel();

in PersistentEntityResourceAssembler will try to get a PersistentEntity by the class BannerComponent but it will return a null, and then further down we try to get the entity.getIdProperty() which throws the null-pointer. Maybe if the ```
repositories.getPersistentEntity


Affects: 2.0 M1 (Codd)

2 votes, 3 watchers

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.