spring-projects / spring-projects/spring-data-rest

Extending filter options when accessing /entities/... [DATAREST-146]

Open
#534 0 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 31, 2020.

type: bug
Dominant language
Java
Stars
958
Forks
568
PR merge metrics
No merged PRs in 30d

Description

Thomas Darimont opened DATAREST-146 and commented

Github Author: jhiemer
Github Last-Updated: 2013-02-20T21:33:26Z
This issue was automatically imported from github

Hi Jon,
me again, who comes up with a request. I talked to @olivergierke last saturday, and a feature that is really missing is the ability to filter based on the current user role. Oliver and me discussed various advantages and disadvantages using @PostAuthorize or @PreAuthorize. Both solutions have significant drawbacks. What we thought of was something like an extension of the query:

java

@Query("where entity.user = :user")
findAll(@Param("user") User user)

The difficulty here is definitely to set this findAll(User user..) as the default lookup, and or even worse, if the current role is the "application administrator", to switch it with a pure findAll() without any user filter.

Perhaps we could use this issue do discuss several scenarios and potential solutions to the problem described.


Reference URL: https://api.github.com/repos/SpringSource/spring-data-rest/issues/72

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.