spring-projects / spring-projects/spring-data-rest
wrong findAll method when Repository extends QueryDslPredicateExecutor [DATAREST-81]
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 958
- Forks
- 568
- PR merge metrics
- No merged PRs in 30d
Description
Kathleen Van Assche opened DATAREST-81 and commented
I have a repository defined as
public interface AlbumRepository extends MongoRepository<Album, ObjectId>, QueryDslPredicateExecutor<Album>
When the RepositoryMethodInvoker is created, the findAll property is set to the method 'public abstract java.lang.Iterable org.springframework.data.querydsl.QueryDslPredicateExecutor.findAll(com.mysema.query.types.Predicate)'. This causes a IllegalArgumentException when the RepositoryEntityController.listEntities calls repoMethodInvoker.findAll().
I attach a demo project (extract of my own project stripped to the bare minimum to reproduce the error). Error occurs when the url http://localhost:8080/test/album is called.
Attachments:
- test.zip (5.05 kB)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with RepositoryMethodInvoker and RepositoryEntityController.listEntities, then reproduce the failure using the attached test.zip project by requesting http://localhost:8080/test/album. Trace how the findAll method is selected when the repository extends QueryDslPredicateExecutor; done means the request no longer raises IllegalArgumentException and uses the appropriate repository method.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100