spring-projects / spring-projects/spring-data-rest
PersistentEntityToJsonSchemaConverter has strong dependency on javax.validation [DATAREST-77]
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 958
- Forks
- 568
- PR merge metrics
- No merged PRs in 30d
Description
Oliver Drotbohm opened DATAREST-77 and commented
The convert(…)) method of PersistentEntityToJsonSchemaConverter references the NotNull annotation of the validation API. This introduces a hard dependency so that it's not really optional anymore
Affects: 1.1.0.M1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names PersistentEntityToJsonSchemaConverter.convert(…) as the entry point; begin there and trace the NotNull validation reference and how that dependency is introduced. Done means the converter no longer imposes a hard validation dependency while retaining its schema behavior; the payload names no test file, so locate relevant converter tests first.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- api, backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100