spring-projects / spring-projects/spring-data-rest

Non-public repository interfaces should not be exposed by default [DATAREST-99]

Open
#427 0 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 31, 2020.

type: enhancement
Dominant language
Java
Stars
958
Forks
568
No merged PRs in 30d

Description

Oliver Drotbohm opened DATAREST-99 and commented

If you make a repository interface package protected it's usually intended only to be used from within that package. So instead of having to explicitly annotated it with @RestResource(exported = false) we could simply not expose interfaces that are not public.

If you'd still like to expose the repository you can still use the annotation

Referenced from: commits https://github.com/spring-projects/spring-data-rest/commit/175f9eab10219c0e6183c993877acf3cc6eb7546, https://github.com/spring-projects/spring-data-rest/commit/310c2f1106a132f5fd56a6a12edc7b180cb70c9d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.