spring-projects / spring-projects/spring-data-rest
Remove use of MatchableHandlerMapping
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 958
- Forks
- 568
- PR merge metrics
- No merged PRs in 30d
Description
The interface is used with HandlerMappingIntrospector to align Spring Security with Spring MVC. It looks like it was introduced in Spring Data REST a long time ago on DelegatingHandlerMapping to ensure delegation doesn't get in the way.
For Spring Framework 7.1 we removed HandlerMappingIntrospector and MatchableHandlerMapping as part of https://github.com/spring-projects/spring-framework/issues/36481, but have had to temporarily revived MatchableHandlerMapping after discovering that Spring Data REST has a compile dependency on it.
It should be possible to just remove it as it has no purpose without HandlerMappingIntrospector.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the project for MatchableHandlerMapping and its use in DelegatingHandlerMapping, then inspect the surrounding Spring MVC and Spring Security integration. Remove the obsolete use and verify that the project still compiles and its relevant tests pass without the interface dependency.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100