spring-projects / spring-projects/spring-data-rest

HalFormsAdaptingResponseBodyAdvice rejects HAL-FORMS request

Open
#2,090 0 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Nov 29, 2021.

status: waiting-for-triage
Dominant language
Java
Stars
958
Forks
568
No merged PRs in 30d

Description

Hi,

Some weeks ago HalFormsAdaptingResponseBodyAdvice was introduced.
It checks if the response body has affordances and if not rejects HAL-FORMS requests with a 406 response.

I am not sure if this is ok, because embeddeds can have affordances too,
at least they get rendered when the main resource has affordances too.

Was this introduced because of the HAL-FORMS spec defines _templates as top-level objects?

If so, how can I prevent adding affordances when implementing a RepresentationModelProcessor<EntityModel<?>> which is also called when a collection resource is requested.

Thx :)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.