spring-projects / spring-projects/spring-data-rest

Unable to create relationships via PUT and ContentType:text/uri-list [DATAREST-1425]

Open
#1,784 0 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 31, 2020.

in: repository type: bug
Dominant language
Java
Stars
958
Forks
568
PR merge metrics
No merged PRs in 30d

Description

kalinwilson opened DATAREST-1425 and commented

At line 321 of RepositoryPropertyReferenceController.java:

if (source.getLinks().hasSingleLink())

should be 

if (!source.getLinks().hasSingleLink())

Correct requests with a single URI fail due to incorrect condition. Previous versions of the code used 

if (source.getLinks().size() != 1)

 

This makes the current version unusable for one-to-one and one-to-many relationships in resource/entity models.


Affects: 3.2 RC3 (Moore)

Reference URL: https://github.com/spring-projects/spring-data-rest/blob/master/spring-data-rest-webmvc/src/main/java/org/springframework/data/rest/webmvc/RepositoryPropertyReferenceController.java#L321

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.