spring-projects / spring-projects/spring-data-rest

No implementation for onBeforeLinkDelete and onAfterLinkDelete in ValidatingRepositoryEventListener [DATAREST-1424]

Open
#1,783 2 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 31, 2020.

in: content-negotiation type: bug
Dominant language
Java
Stars
958
Forks
568
PR merge metrics
No merged PRs in 30d

Description

Pieter Noyens opened DATAREST-1424 and commented

For some reason, there are no override implementations for the onBeforeLinkDelete and onAfterLinkDelete event handler methods in ValidatingRepositoryEventListener. This is also reflected in the documentation at

https://docs.spring.io/spring-data/rest/docs/current/api/org/springframework/data/rest/core/event/ValidatingRepositoryEventListener.html 

Strange enough, these are the only two methods that are not overridden. Also in the official Spring Data REST Reference, at

https://docs.spring.io/spring-data/rest/docs/current/reference/html/#events

for some reason, the BeforeLinkDeleteEvent and AfterLinkDeleteEvent are not documented.

In practice it means that it is not convenient to trigger a set of validators that are linked to the "beforeLinkDelete" and "afterLinkDelete" event strings.

I can see no reason why there is no implementation, completely similar to the onBeforeLinkSave and onAfterLinkSave methods


Affects: 3.1.10 (Lovelace SR10)

Reference URL: https://docs.spring.io/spring-data/rest/docs/current/api/org/springframework/data/rest/core/event/ValidatingRepositoryEventListener.html

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.