spring-projects / spring-projects/spring-data-rest
Empty collections are not serialized properly with default media type json [DATAREST-1346]
Open
@odrotbohm is already working on this.
Since Dec 31, 2020.
type: bug
- Dominant language
- Java
- Stars
- 958
- Forks
- 568
- PR merge metrics
- No merged PRs in 30d
Description
MitchelLabonte opened DATAREST-1346 and commented
When setting the default media type to application/json, an empty collection will be serialized like this:
"content": [ {
"value": [ ],
"relTargetType": "redacted",
"collectionValue": true,
"rel": null
}]
This happens because class AbstractRepositoryRestController, method entitiesToResources maps empty collections to an EmptyCollectionEmbeddedWrapper no matter what media type is used. But, the custom deserializer for EmptyCollectionEmbeddedWrapper is only used when using hal as the mediatype
Affects: 3.1.5 (Lovelace SR5)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.