spring-projects / spring-projects/spring-data-rest
Sort field is ignored when using Custom Controller [DATAREST-1368]
@odrotbohm is already working on this.
Since Dec 31, 2020.
- Dominant language
- Java
- Stars
- 958
- Forks
- 568
- PR merge metrics
- No merged PRs in 30d
Description
Anuj Jamwal opened DATAREST-1368 and commented
Root Cause
When creating a custom controller, there is no way to specify the DomainClass. For a nested resource path like GET /posts/1/comments, the DomainClass is resolved as Post. The Sort Translator ignores the sort fields specified in the query params since they dont belong in the Post class.
Possible Resolution
The current logic in DomainClassResolver looks at the path and takes the first word as the repository. One possible resolution would be to allow the controller to explicitly specify the domain class. That way the DomainClassResolver can use this information to return the domain class rather than looking at the URL
Another method could be have an annotation that can be specified on method itself or have both.
Affects: 3.1.6 (Lovelace SR6)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.