spring-projects / spring-projects/spring-data-rest

Sort field is ignored when using Custom Controller [DATAREST-1368]

Open
#1,701 1 comment 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 31, 2020.

type: bug
Dominant language
Java
Stars
958
Forks
568
PR merge metrics
No merged PRs in 30d

Description

Anuj Jamwal opened DATAREST-1368 and commented

Root Cause

When creating a custom controller, there is no way to specify the DomainClass. For a nested resource path like GET /posts/1/comments, the DomainClass is resolved as Post. The Sort Translator ignores the sort fields specified in the query params since they dont belong in the Post class.

 

Possible Resolution

The current logic in DomainClassResolver looks at the path and takes the first word as the repository. One possible resolution would be to allow the controller to explicitly specify the domain class. That way the DomainClassResolver can use this information to return the domain class rather than looking at the URL

 

Another method could be have an annotation that can be specified on method itself or have both.

 

 


Affects: 3.1.6 (Lovelace SR6)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.