spring-projects / spring-projects/spring-data-rest

Change ArgumentResolverPagingAndSortingTemplateVariables class level visibility from package to public [DATAREST-1319]

Open
#1,679 0 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 31, 2020.

type: enhancement
Dominant language
Java
Stars
958
Forks
568
PR merge metrics
No merged PRs in 30d

Description

kchobantonov opened DATAREST-1319 and commented

Currently if we want to extend org.springframework.data.rest.webmvc.support.RepositoryEntityLinks to provide by default additional link template variable similar to projection then we need to supply the an instance of PagingAndSortingTemplateVariables - see RepositoryRestMvcConfiguration.entityLinks method. Currently the only implementation is ArgumentResolverPagingAndSortingTemplateVariables which means that we need to create either a custom class similar to ArgumentResolverPagingAndSortingTemplateVariables (copy&paste) or make our configuration class that created the entityLinks bean to be in the org.springframework.data.rest.webmvc.config package


No further details from DATAREST-1319

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.