spring-projects / spring-projects/spring-data-rest
Spring Data REST overwrites Spring Data Web-based configuration customisation [DATAREST-1290]
@odrotbohm is already working on this.
Since Dec 31, 2020.
- Dominant language
- Java
- Stars
- 958
- Forks
- 568
- PR merge metrics
- No merged PRs in 30d
Description
Andy Wilkinson opened DATAREST-1290 and commented
When Spring Data Web is being used, configuration can be customised via PageableHandlerMethodArgumentResolverCustomizer and SortHandlerMethodArgumentResolverCustomizer beans. When Spring Data REST is added into the picture, these customizers are still called but their customisations are then overwritten based on RepositoryRestConfiguration. This is confusing for users as it's not immediately obvious why their customizations are no longer taking effect. It's also confusing as it means that there are two different ways of achieving the same thing but you have to know how to pick the right one
Affects: 3.0.10 (Kay SR10), 2.6.15 (Ingalls SR15), 3.1 GA (Lovelace)
Reference URL: https://github.com/spring-projects/spring-boot/issues/14413
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.